Bug 66953
Summary: | Several animations/ tests flakily fail due to fragile setTimeout()-based framework | ||
---|---|---|---|
Product: | WebKit | Reporter: | Peter Kasting <pkasting> |
Component: | Tools / Tests | Assignee: | James Robinson <jamesr> |
Status: | NEW | ||
Severity: | Normal | CC: | abarth, caseq, dino, jchaffraix, simon.fraser, steveblock |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Peter Kasting
The following layout test is flaky on Chromium Snowleopard Debug (see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=animations%2Fnegative-delay.html&group=%40DEPS%20-%20chromium.org ):
animations/negative-delay.html
No idea who should own this. Dimitri, can you triage?
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Peter Kasting
Morphing. There are a number of animations tests with flaky text diffs all due to using what I consider a fragile, timer-based framework. These are at least:
animations/animation-direction-normal.html
animations/change-keyframes.html
animations/change-one-anim.html
animations/combo-transform-translate+scale.html
animations/negative-delay.html
animations/play-state.html
animations/play-state-paused.html
animations/play-state-suspend.html
animations/suspend-resume-animation.html
There are other failing animations tests also, but I'm not sure whether they have the same causes.
We need to deflake these by making the animations tests use some more reliable design.
Ojan suggests James might be able to come up with an idea for a fix.
Peter Kasting
*** Bug 70988 has been marked as a duplicate of this bug. ***
Peter Kasting
*** Bug 71215 has been marked as a duplicate of this bug. ***
Peter Kasting
*** Bug 72485 has been marked as a duplicate of this bug. ***
Adam Barth
Yeah, the animation tests flaky out all the time. Fixing this systematically would be very beneficial.
Steve Block
Committed r100611: <http://trac.webkit.org/changeset/100611>
Steve Block
Committed r100626: <http://trac.webkit.org/changeset/100626>
Dean Jackson
I'm so sick of the current framework for testing. Sick and ashamed.