Bug 66942

Summary: [SKIA] Move forward decl of skia type outside namespace Webkit
Product: WebKit Reporter: Brian Salomon <bsalomon>
Component: New BugsAssignee: Brian Salomon <bsalomon>
Status: RESOLVED FIXED    
Severity: Normal CC: senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Brian Salomon 2011-08-25 07:48:44 PDT 
[SKIA] Move forward decl of skia type outside namespace Webkit
Comment 1 Brian Salomon 2011-08-25 07:49:32 PDT 
Created attachment 105191 [details]
Patch
Comment 2 Brian Salomon 2011-08-25 07:54:28 PDT 
D'oh! I didn't notice that I was adding the forward decl inside of a namespace in my original patch.
Comment 3 Stephen White 2011-08-25 07:57:19 PDT 
Comment on attachment 105191 [details]
Patch

Looks good.  r=me

Did this cause a build failure?  Or just that it would have in the future?
Comment 4 Brian Salomon 2011-08-25 08:01:48 PDT 
There was no build failure. If left as is it would have caused the subclass implementations of grGLInterface() to have to cast from GrGLInterface* to the bogus WebKit::GrGLInterface* type.
Comment 5 WebKit Review Bot 2011-08-25 09:14:34 PDT 
Comment on attachment 105191 [details]
Patch

Clearing flags on attachment: 105191

Committed r93791: <http://trac.webkit.org/changeset/93791>
Comment 6 WebKit Review Bot 2011-08-25 09:14:37 PDT 
All reviewed patches have been landed.  Closing bug.