Bug 66924

Summary: [WebSocket] update pywebsocket to 0.6b5 which support closing handshake test
Product: WebKit Reporter: Takashi Toyoshima <toyoshim>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, tkent, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 66929, 66931, 67191    
Bug Blocks: 66925, 67182    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Takashi Toyoshima 2011-08-25 00:29:42 PDT 
Update pywebsocket to the newest one.
Current 0.6b2 could not verify closing code and reason that a client send to the server.
Comment 1 Takashi Toyoshima 2011-08-25 00:34:18 PDT 
Created attachment 105140 [details]
Patch
Comment 2 Yuta Kitamura 2011-08-25 02:14:19 PDT 
Comment on attachment 105140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105140&action=review

Looks good to me. [Note: I'm not a WebKit reviewer.]

> Tools/ChangeLog:3
> +        [WebSocket] update pywebsocket to 0.6b3 which support closing handshake test

nit: support -> supports
Comment 3 Takashi Toyoshima 2011-08-25 02:20:26 PDT 
Created attachment 105148 [details]
Patch
Comment 4 Kent Tamura 2011-08-25 02:23:52 PDT 
Comment on attachment 105148 [details]
Patch

ok
Comment 5 WebKit Review Bot 2011-08-25 02:38:20 PDT 
Comment on attachment 105148 [details]
Patch

Clearing flags on attachment: 105148

Committed r93767: <http://trac.webkit.org/changeset/93767>
Comment 6 WebKit Review Bot 2011-08-25 02:38:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Yuta Kitamura 2011-08-25 05:35:30 PDT 
Unfortunately this patch caused unexpected failures on Qt bots. According to pywebsocket logs, unexpected 403 responses started to appear after this change on not only Qt bots but also other bots. Thus I rolled out this change.

http://trac.webkit.org/changeset/93776

Logs:

http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r93773%20(14445)/pywebsocket.ws.log-25Aug2011-051651-err.txt

[2011-08-25 05:16:53,685] [WARNING] root: localhost - code 403, message Forbidden
[2011-08-25 05:16:53,710] [ERROR] root: Exception in processing request from: ('127.0.0.1', 64531)
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/SocketServer.py", line 558, in process_request_thread
    self.finish_request(request, client_address)
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/SocketServer.py", line 320, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/Volumes/Big/WebKit-BuildSlave/snowleopard-intel-release-tests-wk2/build/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pywebsocket/mod_pywebsocket/standalone.py", line 381, in __init__
    self, request, client_address, server)
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/SocketServer.py", line 615, in __init__
    self.handle()
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/BaseHTTPServer.py", line 329, in handle
    self.handle_one_request()
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/BaseHTTPServer.py", line 316, in handle_one_request
    if not self.parse_request(): # An error code has been sent, just exit
  File "/Volumes/Big/WebKit-BuildSlave/snowleopard-intel-release-tests-wk2/build/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pywebsocket/mod_pywebsocket/standalone.py", line 447, in parse_request
    self.send_error(e.status)
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/BaseHTTPServer.py", line 357, in send_error
    self.send_response(code, message)
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/BaseHTTPServer.py", line 385, in send_response
    self.send_header('Date', self.date_time_string())
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/BaseHTTPServer.py", line 390, in send_header
    self.wfile.write("%s: %s\r\n" % (keyword, value))
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/socket.py", line 297, in write
    self.flush()
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/socket.py", line 284, in flush
    self._sock.sendall(buffer)
error: [Errno 32] Broken pipe
Comment 8 Takashi Toyoshima 2011-08-29 06:18:38 PDT 
Created attachment 105483 [details]
Patch
Comment 9 Kent Tamura 2011-08-29 22:09:38 PDT 
Comment on attachment 105483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105483&action=review

> Tools/ChangeLog:3
> +        [WebSocket] update pywebsocket to 0.6b4 which supports closing handshake test

What's the difference between 0.6b2 and 0.6b3/b4?
Comment 10 Takashi Toyoshima 2011-08-29 23:01:46 PDT 
Created attachment 105582 [details]
Patch
Comment 11 WebKit Review Bot 2011-08-30 00:46:27 PDT 
Comment on attachment 105582 [details]
Patch

Clearing flags on attachment: 105582

Committed r94055: <http://trac.webkit.org/changeset/94055>
Comment 12 WebKit Review Bot 2011-08-30 00:46:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 13 Takashi Toyoshima 2011-08-30 06:38:01 PDT 
Created attachment 105621 [details]
Patch
Comment 14 Takashi Toyoshima 2011-08-30 06:40:58 PDT 
This is the third trial.
The last change results in failure on Mac 10.5 because pywebsocket 0.6b4 used missing function in Python 2.5.1 which is the default version of Mac 10.5.
Comment 15 Kent Tamura 2011-08-30 18:47:40 PDT 
Comment on attachment 105621 [details]
Patch

ok, try again.
Comment 16 WebKit Review Bot 2011-08-30 19:47:06 PDT 
Comment on attachment 105621 [details]
Patch

Clearing flags on attachment: 105621

Committed r94146: <http://trac.webkit.org/changeset/94146>
Comment 17 WebKit Review Bot 2011-08-30 19:47:11 PDT 
All reviewed patches have been landed.  Closing bug.