Bug 66917

Summary: [chromium] TextureManager overestimates the size of non-RGBA texture formats
Product: WebKit Reporter: Adrienne Walker <enne>
Component: WebCore Misc.Assignee: Adrienne Walker <enne>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, enne, jamesr, nduca, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jamesr: review+, webkit.review.bot: commit-queue-

Description Adrienne Walker 2011-08-24 18:23:50 PDT 
Currently, the TextureManager estimates everything as being 4bpp.  (See the FIXME in memoryUseBytes in TextureManager.cpp.) This should consider the format when calculating the size.
Comment 1 Adrienne Walker 2011-08-31 16:11:51 PDT 
Created attachment 105851 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-31 18:15:29 PDT 
Comment on attachment 105851 [details]
Patch

Attachment 105851 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9578161

New failing tests:
http/tests/loading/empty-urls.html
Comment 3 Vangelis Kokkevis 2011-08-31 22:28:20 PDT 
Comment on attachment 105851 [details]
Patch

This looks good.  I'm curious though, what textures that the texture manager deals with are not 4bpp ?
Comment 4 Adrienne Walker 2011-09-01 09:35:12 PDT 
(In reply to comment #3)
> (From update of attachment 105851 [details])
> This looks good.  I'm curious though, what textures that the texture manager deals with are not 4bpp ?

I recently changed VideoLayerChromium to reserve textures via the texture manager, and that can use luminance textures.
Comment 5 James Robinson 2011-09-01 09:47:22 PDT 
Comment on attachment 105851 [details]
Patch

R=me
Comment 6 Adrienne Walker 2011-09-01 16:03:01 PDT 
Committed r94356: <http://trac.webkit.org/changeset/94356>