Bug 66912

Summary: Improper comment in CoreIPC/ArgumentEncoder.cpp from 66464
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: WebKit Misc.Assignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch mrowe: review+

Michael Saboff
Reported 2011-08-24 17:55:37 PDT
The comment added in <http://trac.webkit.org/changeset/93546> from https://bugs.webkit.org/show_bug.cgi?id=66464 for ArgumentEncoder::grow is not totally correct. The proposed new comment is: // Use system malloc / realloc instead of fastMalloc due to // fastMalloc using MADV_FREE_REUSABLE which doesn't work with // mach messages with OOL message and MACH_MSG_VIRTUAL_COPY. // System malloc also calls madvise(MADV_FREE_REUSABLE) but after first // checking via madvise(CAN_REUSE) that it will succeed. Should this // behavior change we'll need to revisit this.
Attachments
proposed patch (1.94 KB, patch)
2011-08-24 18:02 PDT, Michael Saboff
mrowe: review+
Michael Saboff
Comment 1 2011-08-24 18:02:43 PDT
Created attachment 105109 [details] proposed patch
Michael Saboff
Comment 2 2011-08-24 18:23:49 PDT
Note You need to log in before you can comment on or make changes to this bug.