Bug 66880

Summary: [CMake] Fix build with ENABLE_BLOB or ENABLE_FILE_SYSTEM.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: New BugsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: leandro, paroga
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Third time is a charm none

Raphael Kubo da Costa (:rakuco)
Reported 2011-08-24 12:34:17 PDT
[CMake] Fix build with ENABLE_BLOB or ENABLE_FILE_SYSTEM.
Attachments
Patch (1.98 KB, patch)
2011-08-24 12:38 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Patch (1.87 KB, patch)
2011-08-24 12:56 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Third time is a charm (1.72 KB, patch)
2011-08-24 13:03 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-08-24 12:38:08 PDT
Created attachment 105045 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2011-08-24 12:38:57 PDT
CC'ing Patrick as this patch changes a global CMakeLists.txt.
Patrick R. Gansterer
Comment 3 2011-08-24 12:45:56 PDT
Comment on attachment 105045 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105045&action=review > Source/WebCore/CMakeLists.txt:1552 > + fileapi/FileException.idl Why do you add them twice? Wouldn't it be cooler if you add an addition if (ENABLE_BLOB OR ENABLE_FILE_SYSTEM) section?
Raphael Kubo da Costa (:rakuco)
Comment 4 2011-08-24 12:52:42 PDT
Stupid me, didn't notice that before. Will work on a new version in a minute.
Raphael Kubo da Costa (:rakuco)
Comment 5 2011-08-24 12:56:18 PDT
Created attachment 105050 [details] Patch
Patrick R. Gansterer
Comment 6 2011-08-24 12:58:29 PDT
Comment on attachment 105050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105050&action=review > Source/WebCore/CMakeLists.txt:1558 > + fileapi/OperationNotAllowedException.idl and what about OperationNotAllowedException.idl? ;-)
Raphael Kubo da Costa (:rakuco)
Comment 7 2011-08-24 13:01:36 PDT
I can't even think of a proper excuse now ;)
Raphael Kubo da Costa (:rakuco)
Comment 8 2011-08-24 13:03:28 PDT
Created attachment 105052 [details] Third time is a charm
Patrick R. Gansterer
Comment 9 2011-08-24 15:29:18 PDT
Committed r93744: <http://trac.webkit.org/changeset/93744>
Raphael Kubo da Costa (:rakuco)
Comment 10 2011-08-25 06:48:03 PDT
Comment on attachment 105052 [details] Third time is a charm Cleaning flags, patch committed.
Note You need to log in before you can comment on or make changes to this bug.