[EFL] Do not always return the cached frame name.

• Component: New Bugs
• Status: RESOLVED FIXED

[Raphael Kubo da Costa (:rakuco)]

[EFL] Do not always return the cached frame name.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 104993 [details]
Patch

[Ryuan Choi]

Comment on attachment 104993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104993&action=review

> Source/WebKit/efl/ewk/ewk_frame.cpp:358
> +    const WTF::String s = sd->frame->tree()->uniqueName();
> +    const WTF::CString cs = s.utf8();

Informal r+.

But, how do you think about making above as one line and giving better name?

[Raphael Kubo da Costa (:rakuco)]

It is possible, but I would rather not do that in this patch, as it is not strictly related to this change.

[Kenneth Rohde Christiansen]

Comment on attachment 104993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104993&action=review

> Source/WebKit/efl/ewk/ewk_frame.cpp:361
> +    if ((sd->name) && (!strcmp(sd->name, cs.data())))
> +        return sd->name;

WebKit's string classes can do comparison. Please avoid using pure C methods such as strcmp.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 107181 [details]
Use operator== instead of strcmp

[Antonio Gomes]

Comment on attachment 107181 [details]
Use operator== instead of strcmp

View in context: https://bugs.webkit.org/attachment.cgi?id=107181&action=review

> Source/WebKit/efl/ewk/ewk_frame.cpp:357
> +    const WTF::String frameName = sd->frame->tree()->uniqueName();

nit: const here seem unusual.

> Source/WebKit/efl/ewk/ewk_frame.cpp:359
> +    if ((sd->name) && (sd->name == frameName))

nit: extra ()'s

[WebKit Review Bot]

Comment on attachment 107181 [details]
Use operator== instead of strcmp

Clearing flags on attachment: 107181

Committed r95033: <http://trac.webkit.org/changeset/95033>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.