Bug 66843 – Color chooser closes on "open new tab"

• Component: Forms
• Status: RESOLVED WONTFIX

[Keishi Hattori]

Color chooser closes on "open new tab" and "open Web Inspector".

I caused this bug while solving the layer violation in Bug 62619.

[Keishi Hattori]

Created attachment 104978 [details]
patch

[Darin Adler]

Comment on attachment 104978 [details]
patch

Not a comment about this patch, but about the original code.

This seems like bad encapsulation. transitionToCommitted in the loader does not seem like the right place to be directly manipulating UI; there is no other code like that in there.

On a separate note, this implements a UI policy that is not universal; this is not how color panels work on Macs. Closing the window that you used to trigger the color panel does not make it go away.

[Keishi Hattori]

> On a separate note, this implements a UI policy that is not universal; this is not how color panels work on Macs. Closing the window that you used to trigger the color panel does not make it go away.

You are absolutely right. I will abandon this idea to close the color panel when the element disappears for OS X.

> This seems like bad encapsulation. transitionToCommitted in the loader does not seem like the right place to be directly manipulating UI; there is no other code like that in there.

I knew it was wrong but transitionToCommitted was the only place I could find. I will remove these lines immediately in an upcoming patch.

I will close this bug as it is no longer relavent.

Thanks for taking a look!

[Eric Seidel (no email)]

Comment on attachment 104978 [details]
patch

Cleared review? from attachment 104978 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).