Bug 66831

Summary: WebSearchableFormData crashes when given a detached HTMLFormElement
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Adam Barth 2011-08-23 18:01:04 PDT 
WebSearchableFormData crashes when given a detached HTMLFormElement
Comment 1 Adam Barth 2011-08-23 18:02:09 PDT 
Created attachment 104948 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-23 18:05:08 PDT 
Comment on attachment 104948 [details]
Patch

Attachment 104948 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9480721
Comment 3 Adam Barth 2011-08-23 18:16:44 PDT 
Created attachment 104952 [details]
Patch
Comment 4 Dimitri Glazkov (Google) 2011-08-23 20:33:51 PDT 
Comment on attachment 104952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104952&action=review

> Source/WebKit/chromium/tests/data/form.html:1
> +<form action="about:blank" method="POST"></form>

This test is too simple!
Comment 5 Adam Barth 2011-08-23 20:35:20 PDT 
(In reply to comment #4)
> (From update of attachment 104952 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=104952&action=review
> 
> > Source/WebKit/chromium/tests/data/form.html:1
> > +<form action="about:blank" method="POST"></form>
> 
> This test is too simple!

I could take the "method" attribute away.  :)
Comment 6 WebKit Review Bot 2011-08-23 21:32:56 PDT 
Comment on attachment 104952 [details]
Patch

Clearing flags on attachment: 104952

Committed r93692: <http://trac.webkit.org/changeset/93692>
Comment 7 WebKit Review Bot 2011-08-23 21:33:00 PDT 
All reviewed patches have been landed.  Closing bug.