Bug 66821

Summary: [skia] Outlines for inline elements have small gaps
Product: WebKit Reporter: Ben Wells <benwells>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: jamesr, kbr, mikelawther, reed, schenney, senorblanco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 72062    
Bug Blocks:    
Attachments:
Description Flags
Test case none

Ben Wells
Reported 2011-08-23 16:33:52 PDT
Created attachment 104928 [details] Test case When inline elements which span multiple lines have outlines, the outlines have gaps in them.
Attachments
Test case (1.54 KB, text/html)
2011-08-23 16:33 PDT, Ben Wells 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ben Wells
Comment 1 2011-10-20 16:45:01 PDT
This appears to be due to skia drawing polygons differently to CG when anti-aliasing is not used. This only happens now via drawConvexPolygon, when called with anti-aliasing false, which doesn't happen much. Skia draws slightly less pixels than CG. Something like: any pixels which aren't fully on or off (i.e. they are on an edge which isn't straight up/down or left/right) are drawn on in CG. In skia they are drawn on if the fill is on the left of the edge and off if the fill is on the right. Maybe this makes drawing adjacent polygons (like when triangulating larger shapes) easier in skia and is deliberate. I have 'fixed' this minor issue by changing skias path filling code at a deep level but that is pretty heavy and would probably break a million other really important things. This difference shows up in other edge cases in border / outline rendering, e.g. webkit bug 70741. Right now its not much of a problem and is perhaps not worth fixing.
Ben Wells
Comment 2 2011-11-10 14:51:46 PST
Related border bug is webkit bug 70471 (not 70741).
Note You need to log in before you can comment on or make changes to this bug.