Bug 66814

Summary:

[chromium] Renderer crashes when about:gpucrash is loaded

Product:

WebKit

Reporter:

Iain Merrick <husky>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

husky, kbr, nduca, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

66820

Attachments:

Description	Flags
Patch	none
Patch	none

Iain Merrick

Reported 2011-08-23 15:41:24 PDT

about:gpucrash simulates a GPU process crash. The renderer should recover seamlessly.

Attachments
Patch (5.78 KB, patch) 2011-08-23 16:04 PDT, Iain Merrick	no flags	Details Formatted Diff Diff
Patch (5.84 KB, patch) 2011-08-23 17:03 PDT, Iain Merrick	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Iain Merrick

Comment 1 2011-08-23 16:04:46 PDT

Created attachment 104924 [details] Patch

James Robinson

Comment 2 2011-08-23 16:10:04 PDT

Comment on attachment 104924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104924&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:2667 > + // Force ViewHostMsg_DidActivateAcceleratedCompositing to be sent so > + // that the browser process can reacquire surfaces. > + m_isAcceleratedCompositingActive = false; > + setIsAcceleratedCompositingActive(success); why is this different from the previous logic? looks like you broke page overlays here, any particular reason to change that logic too?

Iain Merrick

Comment 3 2011-08-23 16:58:44 PDT

Comment on attachment 104924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104924&action=review >> Source/WebKit/chromium/src/WebViewImpl.cpp:2667 >> + setIsAcceleratedCompositingActive(success); > > why is this different from the previous logic? > > looks like you broke page overlays here, any particular reason to change that logic too? setRootGraphicsLayer was calling setIsAcceleratedCompositingActive, in addition to the stuff that was causing the crash. It looked to me like the page overlay update was redundant, because that is called on line 2628 inside setIsAcceleratedCompositingActive, but that only happens if m_layerTreeHost is null. So you're right, it's still needed here -- I'll add it back in.

Iain Merrick

Comment 4 2011-08-23 17:03:47 PDT

Created attachment 104934 [details] Patch

James Robinson

Comment 5 2011-08-23 17:15:13 PDT

Comment on attachment 104934 [details] Patch Ah, I see. Very subtle. It seems like we've done something wrong with setIsAcceleratedCompositingActive() if we need it do have side effects for true->true transitions. Maybe we need a separate notion of 'toggling compositing on/off' vs 'please update yourself due to some compositing change'. That would be for a different patch, though.

WebKit Review Bot

Comment 6 2011-08-23 18:18:13 PDT

Comment on attachment 104934 [details] Patch Clearing flags on attachment: 104934 Committed r93679: <http://trac.webkit.org/changeset/93679>

WebKit Review Bot

Comment 7 2011-08-23 18:18:17 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.