Bug 66811

Summary: ResourceRequest::setStorageSession should update NSURLRequest as well
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: PlatformAssignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, jberlin, psolanki
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Pratik Solanki
Reported 2011-08-23 14:22:05 PDT
ResourceRequest::setStorageSession() creates a new CFMutableURLRequest and stores it as its m_cfRequest. This means, that when USE(CFNETWORK) is enabled, the CF and NS requests are out of sync. We should update the m_nsRequest field as well in that method.
Attachments
Patch (1.50 KB, patch)
2011-08-23 15:39 PDT, Pratik Solanki 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2011-08-23 15:37:41 PDT
by "when USE(CFNETWORK) is enabled", I meant "when USE(CFNETWORK) is enabled on Mac OSX"
Pratik Solanki
Comment 2 2011-08-23 15:39:04 PDT
Created attachment 104920 [details] Patch
Pratik Solanki
Comment 3 2011-08-23 15:55:48 PDT
<rdar://problem/10010841>
Pratik Solanki
Comment 4 2011-08-23 16:05:22 PDT
Committed r93648: <http://trac.webkit.org/changeset/93648>
Note You need to log in before you can comment on or make changes to this bug.