Bug 66810

Summary: platform/graphics/skia should stay in float space when possible to avoid inaccurate rendering
Product: WebKit Reporter: John Bates <jbates>
Component: New BugsAssignee: Mike Reed <reed>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, kbr, pkasting, reed, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

John Bates
Reported 2011-08-23 14:17:30 PDT
This depends on skia adding float support to some functions: http://code.google.com/p/skia/issues/detail?id=345 Once that is implemented, we can remove the int conversion in platform/graphics/skia/SkiaUtils.cpp IntersectRectAndRegion.
Attachments
Patch (2.83 KB, patch)
2011-08-24 06:45 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
Patch (2.87 KB, patch)
2011-08-24 06:55 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
John Bates
Comment 1 2011-08-23 14:19:48 PDT
See https://bugs.webkit.org/show_bug.cgi?id=66798 for discussion of the rendering results.
Mike Reed
Comment 2 2011-08-24 06:45:57 PDT
Created attachment 104990 [details] Patch
Mike Reed
Comment 3 2011-08-24 06:55:50 PDT
Created attachment 104992 [details] Patch
Mike Reed
Comment 4 2011-08-24 06:56:43 PDT
Change ClipRectToCanvas to call existing method to get the clip bounds in local (float) coordinates.
John Bates
Comment 5 2011-08-24 09:36:16 PDT
lol, nicely done. Need a webkit committer to give the r+ (Peter?).
Peter Kasting
Comment 6 2011-08-24 10:32:10 PDT
(In reply to comment #5) > lol, nicely done. Need a webkit committer to give the r+ (Peter?). Sorry, you need a WebKit reviewer, and I'm only a committer. I can't r+.
Kenneth Russell
Comment 7 2011-08-24 12:07:36 PDT
Comment on attachment 104992 [details] Patch Looks good. I'm assuming no layout tests need updates for this change.
WebKit Review Bot
Comment 8 2011-08-24 13:09:05 PDT
Comment on attachment 104992 [details] Patch Clearing flags on attachment: 104992 Committed r93725: <http://trac.webkit.org/changeset/93725>
WebKit Review Bot
Comment 9 2011-08-24 13:09:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.