Bug 66810 - platform/graphics/skia should stay in float space when possible to avoid inaccurate rendering
Summary: platform/graphics/skia should stay in float space when possible to avoid inac...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Reed
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-23 14:17 PDT by John Bates
Modified: 2011-08-24 13:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2011-08-24 06:45 PDT, Mike Reed 		no flags Details | Formatted Diff | Diff
Patch (2.87 KB, patch)
2011-08-24 06:55 PDT, Mike Reed 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Bates 2011-08-23 14:17:30 PDT 
This depends on skia adding float support to some functions:
http://code.google.com/p/skia/issues/detail?id=345

Once that is implemented, we can remove the int conversion in platform/graphics/skia/SkiaUtils.cpp IntersectRectAndRegion.
Comment 1 John Bates 2011-08-23 14:19:48 PDT 
See https://bugs.webkit.org/show_bug.cgi?id=66798 for discussion of the rendering results.
Comment 2 Mike Reed 2011-08-24 06:45:57 PDT 
Created attachment 104990 [details]
Patch
Comment 3 Mike Reed 2011-08-24 06:55:50 PDT 
Created attachment 104992 [details]
Patch
Comment 4 Mike Reed 2011-08-24 06:56:43 PDT 
Change ClipRectToCanvas to call existing method to get the clip bounds in local (float) coordinates.
Comment 5 John Bates 2011-08-24 09:36:16 PDT 
lol, nicely done. Need a webkit committer to give the r+ (Peter?).
Comment 6 Peter Kasting 2011-08-24 10:32:10 PDT 
(In reply to comment #5)
> lol, nicely done. Need a webkit committer to give the r+ (Peter?).

Sorry, you need a WebKit reviewer, and I'm only a committer.  I can't r+.
Comment 7 Kenneth Russell 2011-08-24 12:07:36 PDT 
Comment on attachment 104992 [details]
Patch

Looks good. I'm assuming no layout tests need updates for this change.
Comment 8 WebKit Review Bot 2011-08-24 13:09:05 PDT 
Comment on attachment 104992 [details]
Patch

Clearing flags on attachment: 104992

Committed r93725: <http://trac.webkit.org/changeset/93725>
Comment 9 WebKit Review Bot 2011-08-24 13:09:09 PDT 
All reviewed patches have been landed.  Closing bug.