Bug 66803

Summary: Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
Product: WebKit Reporter: Cary Clark <caryclark>
Component: New BugsAssignee: Cary Clark <caryclark>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Cary Clark
Reported 2011-08-23 13:10:27 PDT
Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
Attachments
Patch (1.86 KB, patch)
2011-08-23 13:13 PDT, Cary Clark 		no flags
DetailsFormatted DiffDiff
Patch (1.98 KB, patch)
2011-08-23 13:20 PDT, Cary Clark 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Cary Clark
Comment 1 2011-08-23 13:13:41 PDT
Created attachment 104903 [details] Patch
Cary Clark
Comment 2 2011-08-23 13:20:05 PDT
Created attachment 104904 [details] Patch
James Robinson
Comment 3 2011-08-23 13:28:54 PDT
Comment on attachment 104904 [details] Patch Looks sane. I guess we'll have to audit all of the uses of WebCanvas anywhere, right?
Cary Clark
Comment 4 2011-08-23 13:36:55 PDT
I did search everywhere for graphicsContextWithGraphicsPort, since it takes a void*, to see if there were any other possible mismatches, but all other uses look fine. I don't know if there are other common Apple framework calls that take void* to check.
WebKit Review Bot
Comment 5 2011-08-23 16:18:49 PDT
Comment on attachment 104904 [details] Patch Clearing flags on attachment: 104904 Committed r93653: <http://trac.webkit.org/changeset/93653>
WebKit Review Bot
Comment 6 2011-08-23 16:18:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.