Bug 66769

Summary:

Web Inspector: rename sourceFile to (raw|ui)SourceCode in DebuggerPresentationModel.

Product:

WebKit

Reporter:

Pavel Podivilov <podivilov>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Podivilov <podivilov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	pfeldman: review+

Pavel Podivilov

Reported 2011-08-23 06:01:00 PDT

Web Inspector: rename sourceFile to (raw|ui)SourceCode in DebuggerPresentationModel. Rename sourceFile to (raw|ui)SourceCode and store RawSourceCode and UISourceCode instances in separate maps. This is the last step before actually switching to RawSourceCode<->UISourceCode scheme (currently only RawSourceCode is used).

Attachments
Patch (38.09 KB, patch) 2011-08-23 06:02 PDT, Pavel Podivilov	no flags	Details Formatted Diff Diff
Patch (41.21 KB, patch) 2011-08-25 07:18 PDT, Pavel Podivilov	pfeldman: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Podivilov

Comment 1 2011-08-23 06:02:33 PDT

Created attachment 104831 [details] Patch

Pavel Feldman

Comment 2 2011-08-25 00:12:59 PDT

Comment on attachment 104831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104831&action=review > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:36 > + this._uiSourceCode = {}; I thought ui source code items belong to corresponding raw source code items. > Source/WebCore/inspector/front-end/SourceFile.js:77 > + uiLocation.uiSourceCode = this; Defining class for UILocation would help understanding the code.

Pavel Podivilov

Comment 3 2011-08-25 07:18:22 PDT

Created attachment 105181 [details] Patch

Pavel Podivilov

Comment 4 2011-08-25 07:19:02 PDT

Please take another look. (In reply to comment #2) > (From update of attachment 104831 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104831&action=review > > > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:36 > > + this._uiSourceCode = {}; > > I thought ui source code items belong to corresponding raw source code items. Agree. > > > Source/WebCore/inspector/front-end/SourceFile.js:77 > > + uiLocation.uiSourceCode = this; > > Defining class for UILocation would help understanding the code. Done.

Pavel Podivilov

Comment 5 2011-08-29 08:14:36 PDT

Committed r93977: <http://trac.webkit.org/changeset/93977>

Note You need to log in before you can comment on or make changes to this bug.