Bug 66760 – TiledBackingStore: Untie the tile implementation from the platform.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jocelyn Turcotte]

TiledBackingStore: Untie the tile implementation from the platform.

[Jocelyn Turcotte]

Created attachment 104813 [details]
Patch

[Benjamin Poulain]

Comment on attachment 104813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104813&action=review

> Source/WebCore/platform/graphics/Tile.h:47
> +    virtual const Tile::Coordinate& coordinate() const  = 0;

Two spaces before =.

> Source/WebCore/platform/graphics/TiledBackingStore.h:44
> +    TiledBackingStore(TiledBackingStoreClient*, PassOwnPtr<TiledBackingStoreBackend> = TiledBackingStoreBackend::create() );

There is an extra space before the last parenthesis.

[Kenneth Rohde Christiansen]

Comment on attachment 104813 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104813&action=review

> Source/WebCore/platform/graphics/TiledBackingStore.h:78
> +    double tileDistance(const IntRect& viewport, const Tile::Coordinate&);

Why is this one not const?

> Source/WebCore/platform/graphics/qt/TileQt.h:26
> +#include "IntPointHash.h"

I didnt even know we had that :-) Where are you using that?

[Jocelyn Turcotte]

Created attachment 105004 [details]
Patch

Fixed all issues.

[Kenneth Rohde Christiansen]

Comment on attachment 105004 [details]
Patch

I really like this patch. Good work Jocelyn. One question, it is possible (or will it be) to suspend the painting etc and resize? I am asking this due to how we currently are handing the orientation change on the N9. We only resume and relayout when the orientation ends. You can easily test this on google.com (using iphone UA due to us not getting Tier 1 content).

[Jocelyn Turcotte]

Committed r93777: <http://trac.webkit.org/changeset/93777>