Bug 66753

Summary:

Web Inspector: [Chromium] Fix handling of aggregate names in profiler

Product:

WebKit

Reporter:

Mikhail Naganov <mnaganov>

Component:

Web Inspector (Deprecated)

Assignee:

Mikhail Naganov <mnaganov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+, mnaganov: commit-queue-

Mikhail Naganov

Reported 2011-08-23 03:36:49 PDT

Currently in _buildAggregates we check for existing aggregate names using the "in" operator, and it looks up in the prototype chain, so e.g. "'toString' in {} === true". That is, having an aggregate named "toString" will cause a problem.

Attachments
Patch (1.71 KB, patch) 2011-08-23 03:38 PDT, Mikhail Naganov	pfeldman: review+ mnaganov: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mikhail Naganov

Comment 1 2011-08-23 03:38:49 PDT

Created attachment 104808 [details] Patch

Mikhail Naganov

Comment 2 2011-08-23 05:21:40 PDT

Manually committed http://trac.webkit.org/changeset/93591 Web Inspector: [Chromium] Fix handling of aggregate names in profiler. https://bugs.webkit.org/show_bug.cgi?id=66753 Reviewed by Pavel Feldman. * inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshot.prototype._buildAggregates):

Note You need to log in before you can comment on or make changes to this bug.