Bug 66753

Summary: Web Inspector: [Chromium] Fix handling of aggregate names in profiler
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Web Inspector (Deprecated)Assignee: Mikhail Naganov <mnaganov>
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Patch pfeldman: review+, mnaganov: commit-queue-

Description Mikhail Naganov 2011-08-23 03:36:49 PDT
Currently in _buildAggregates we check for existing aggregate names using the "in" operator, and it looks up in the prototype chain, so e.g. "'toString' in {} === true". That is, having an aggregate named "toString" will cause a problem.
Comment 1 Mikhail Naganov 2011-08-23 03:38:49 PDT
Created attachment 104808 [details]
Comment 2 Mikhail Naganov 2011-08-23 05:21:40 PDT
Manually committed http://trac.webkit.org/changeset/93591

        Web Inspector: [Chromium] Fix handling of aggregate names in profiler.

        Reviewed by Pavel Feldman.

        * inspector/front-end/HeapSnapshot.js: