Summary: | [Chromium]WebWorkerClientImpl should always invoke InspectorIntrumentation on main thread | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dmitry Lomov <dslomov> | ||||||||||
Component: | WebCore Misc. | Assignee: | Dmitry Lomov <dslomov> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ap, dimich, levin, pfeldman, webkit.review.bot, yurys | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Dmitry Lomov
2011-08-23 01:00:28 PDT
Created attachment 104802 [details]
This patch moves calls to InspectorInstrumentation from WebWorkerClientImpl to WorkerMessagingProxy
Attachment 104802 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit/chromium/ChangeLog:5: Line contains tab character. [whitespace/tab] [5]
Source/WebKit/chromium/ChangeLog:6: Line contains tab character. [whitespace/tab] [5]
Source/WebKit/chromium/ChangeLog:7: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5]
Total errors found: 6 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 104803 [details]
Indentation fixed
Comment on attachment 104803 [details]
Indentation fixed
Looks good. Could you please add ASSERT(isMainThread()) into instrumentationForPage(Page* page) (InstrumentingAgents.cpp) as a drive by? That way it'll hit us prior to thread sanitizer next time.
Created attachment 104905 [details]
CR feedback
Created attachment 104907 [details]
One more indentation fix..
Comment on attachment 104907 [details] One more indentation fix.. Clearing flags on attachment: 104907 Committed r93654: <http://trac.webkit.org/changeset/93654> All reviewed patches have been landed. Closing bug. |