Bug 66749
| Summary: | [Qt] Assertion fails in three regression tests after r93567 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Renata Hodovan <rhodovan.u-szeged> |
| Component: | Frames | Assignee: | Rafael Brandao <rafael.lobo> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | allan.jensen, ap, ggaren, lakshmiprasannag10, noam, ossy, rafael.lobo, zherczeg |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 53191, 79666, 79668 | ||
Renata Hodovan
Three tests have assertion error in debug mode on x86-32 Linux Qt:
ASSERTION FAILED: webFrame.isNull()
../../../../Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp(1323) : virtual WTF::PassRefPtr<WebCore::Frame> WebCore::FrameLoaderClientQt::createFrame(const WebCore::KURL&, const WTF::String&, WebCore::HTMLFrameOwnerElement*, const WTF::String&, bool, int, int)
Segmentation fault
The failed tests are:
fast/frames/iframe-onload-remove-self-no-crash.html
fast/loader/create-frame-in-DOMContentLoaded.html
fast/loader/frame-creation-removal.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Renata Hodovan
Committed r93581: <http://trac.webkit.org/changeset/93581>
Renata Hodovan
The error is still exist.
Alexey Proskuryakov
Why was this assigned to me? Even provided that it started with my check-in, I have no way to work on this bug.
Notably, Mac WebKit1 also has this assertion, which doesn't get hit.
lakshmig
The Asset condition is checking webFrame object existence, it has not been freed any where before the Assert instruction, so the webFrame.isNull() instruction is returning false. After adding following instructions all the test cases mentioned above are passing.
delete webFrame ;
ASSERT(webFrame.isNull());
Allan Sandfeld Jensen
I think the assert can be removed. The frame is not always deleted right away, and none of the other implementations of FrameLoaderClient has a similar assert.
Rafael Brandao
I think the first step is to figure out why there's this assumption that it will be deleted at that point. I will take a look.
Rafael Brandao
It looks like this is fixed already. Tests are passing and I can't find these ones skipped. Closing bug.