Bug 66733

Summary:

RenderText::computePreferredLogicalWidths() should measure words with trailing spaces

Product:

WebKit

Reporter:

Ned Holbrook <ned>

Component:

Text

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, levin, mitz, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

66498

Attachments:

Description	Flags
Proposed changes.	none
Added pixel results.	mitz: review+, webkit.review.bot: commit-queue-

Ned Holbrook

Reported 2011-08-22 17:03:05 PDT

This function should measure complex text in the same manner as RenderBlock::LineBreaker::nextLineBreak().

Attachments
Proposed changes. (4.57 KB, patch) 2011-08-22 17:11 PDT, Ned Holbrook	no flags	Details Formatted Diff Diff
Added pixel results. (24.60 KB, patch) 2011-08-22 17:35 PDT, Ned Holbrook	mitz: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ned Holbrook

Comment 1 2011-08-22 17:11:34 PDT

Created attachment 104768 [details] Proposed changes. Note that I shamelessly stole the test from Mitz.

mitz

Comment 2 2011-08-22 17:14:56 PDT

Comment on attachment 104768 [details] Proposed changes. Looks good but please run run-webkit-tests with the --pixel option and include the -expected.png file in your patch.

Ned Holbrook

Comment 3 2011-08-22 17:35:30 PDT

Created attachment 104772 [details] Added pixel results.

WebKit Review Bot

Comment 4 2011-08-22 18:08:48 PDT

Comment on attachment 104772 [details] Added pixel results. Attachment 104772 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9479039 New failing tests: fast/text/complex-preferred-logical-widths.html

Ned Holbrook

Comment 5 2011-08-23 11:07:54 PDT

(In reply to comment #4) > New failing tests: > fast/text/complex-preferred-logical-widths.html This is the test I just added. What does it mean?

mitz

Comment 6 2011-08-26 13:44:08 PDT

Fixed in <http://trac.webkit.org/r93909>.

Ryosuke Niwa

Comment 7 2011-08-30 00:05:38 PDT

The test added by this patch is failing on Snow Leopard: http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r93929%20(1875)/fast/text/complex-preferred-logical-widths-pretty-diff.html Does it just need a rebaseline?

Ryosuke Niwa

Comment 8 2011-08-30 00:17:48 PDT

Also failing on Windows: http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r94044%20(15853)/fast/text/complex-preferred-logical-widths-pretty-diff.html

mitz

Comment 9 2011-08-30 09:27:11 PDT

(In reply to comment #7) > The test added by this patch is failing on Snow Leopard: > http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r93929%20(1875)/fast/text/complex-preferred-logical-widths-pretty-diff.html > > Does it just need a rebaseline? The test had correct results and was passing as of r93909. Then incorrect results (which are incorrect for both Lion and Snow Leopard) were landed in <http://trac.webkit.org/r93924>.

Ryosuke Niwa

Comment 10 2011-08-30 09:34:16 PDT

(In reply to comment #9) > The test had correct results and was passing as of r93909. Then incorrect results (which are incorrect for both Lion and Snow Leopard) were landed in <http://trac.webkit.org/r93924>. :( +levin.

David Levin

Comment 11 2011-08-30 09:51:01 PDT

(In reply to comment #10) > (In reply to comment #9) > > The test had correct results and was passing as of r93909. Then incorrect results (which are incorrect for both Lion and Snow Leopard) were landed in <http://trac.webkit.org/r93924>. > > :( +levin. I don't know what happened there. Obviously a mistake -- yep I do them :). Feel free to revert it. I suspect it was an issue with the rebaselining tool that I didn't catch before submitting.

David Levin

Comment 12 2011-08-30 10:42:53 PDT

Note You need to log in before you can comment on or make changes to this bug.