Bug 66726

Summary: Add CSS parsing for -webkit-flex-align
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, hyatt, macpherson, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch none

Tony Chang
Reported 2011-08-22 15:51:11 PDT
Add CSS parsing for -webkit-flex-align
Attachments
Patch (16.35 KB, patch)
2011-08-22 15:53 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-08-22 15:53:44 PDT
Created attachment 104757 [details] Patch
Luke Macpherson
Comment 2 2011-08-22 16:24:03 PDT
Comment on attachment 104757 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104757&action=review > LayoutTests/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Not a reviewer, but pretty familiar with this code, so for what it's worth it looks ok to me (comment aside). > Source/WebCore/css/CSSValueKeywords.in:479 > +// baseline Did you mean to leave these commented out?
Tony Chang
Comment 3 2011-08-22 16:27:06 PDT
Comment on attachment 104757 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104757&action=review >> Source/WebCore/css/CSSValueKeywords.in:479 >> +// baseline > > Did you mean to leave these commented out? Yes, they're defined elsewhere in the file because other CSS properties use these values. For example, 'middle' is a value for vertical align. I took the pattern of commenting out valid values from elsewhere in the file.
WebKit Review Bot
Comment 4 2011-08-26 13:42:42 PDT
Comment on attachment 104757 [details] Patch Clearing flags on attachment: 104757 Committed r93908: <http://trac.webkit.org/changeset/93908>
WebKit Review Bot
Comment 5 2011-08-26 13:42:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.