| Summary: | Add CSS parsing for -webkit-flex-align | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> | ||||
| Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric, hyatt, macpherson, ojan, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 62048 | ||||||
| Attachments: |
|
||||||
|
Description
Tony Chang
2011-08-22 15:51:11 PDT
Created attachment 104757 [details]
Patch
Comment on attachment 104757 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104757&action=review > LayoutTests/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Not a reviewer, but pretty familiar with this code, so for what it's worth it looks ok to me (comment aside). > Source/WebCore/css/CSSValueKeywords.in:479 > +// baseline Did you mean to leave these commented out? Comment on attachment 104757 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104757&action=review >> Source/WebCore/css/CSSValueKeywords.in:479 >> +// baseline > > Did you mean to leave these commented out? Yes, they're defined elsewhere in the file because other CSS properties use these values. For example, 'middle' is a value for vertical align. I took the pattern of commenting out valid values from elsewhere in the file. Comment on attachment 104757 [details] Patch Clearing flags on attachment: 104757 Committed r93908: <http://trac.webkit.org/changeset/93908> All reviewed patches have been landed. Closing bug. |