Summary: | Sampling counter support is in the bytecode directory | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | barraclough, fpizlo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Filip Pizlo
2011-08-22 15:11:23 PDT
Created attachment 104749 [details]
the patch
Attachment 104749 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/runtime/SamplingCounter.h:84: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/JavaScriptCore/runtime/SamplingCounter.h:92: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/JavaScriptCore/runtime/SamplingCounter.h:105: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/JavaScriptCore/runtime/SamplingCounter.h:147: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/JavaScriptCore/runtime/SamplingCounter.h:148: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 5 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 104754 [details]
the patch (fix style)
Comment on attachment 104754 [details] the patch (fix style) Clearing flags on attachment: 104754 Committed r93560: <http://trac.webkit.org/changeset/93560> All reviewed patches have been landed. Closing bug. |