Bug 66719
| Summary: | check-webkit-style requires 2 spaces before comment in Python 1 in c++ | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aakash_jain, abarth, ap, colineddie05, darin, dbates, levin, msoftat, munna1991vikram, nitunasai, rajsnh200, sagar73510, sijesoyo |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=171506 | ||
Eric Seidel (no email)
Source/WebCore/rendering/InlineIterator.h:216: One space before end of line comments [whitespace/comments] [5]
check-webkit-style (due to PEP8) will tell me to do the opposite in my python code.
We should pick one. I proposed PEP8 be damned and we standardize on 1-space everywhere.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Levin
TLDR: I don't care either way.
I would be fine with using 1 space in python code (though I do like sticking with PEP8 as I think it makes it easier for people to do our style since it would be the standard style).
I honestly don't care too much about these issues (except for the fact that chromium disobeys PEP8 in naming and indents, which makes it harder for us to port code quickly and simply, but I lost that battle -- btw, if chromium followed PEP8 more closely, I would care more about this issue as it would make it uglier to port code).