Bug 66712

Summary: The UI process should keep track of whether a plug-in has focus or not
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: Plug-insAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Anders Carlsson
Reported 2011-08-22 14:18:48 PDT
The UI process should keep track of whether a plug-in has focus or not
Attachments
Patch (15.95 KB, patch)
2011-08-22 14:22 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-08-22 14:22:11 PDT
Created attachment 104737 [details] Patch
Darin Adler
Comment 2 2011-08-22 14:24:22 PDT
Comment on attachment 104737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104737&action=review > Source/WebKit2/ChangeLog:3 > + The UI process should keep track of whether a plug-in has focus or not Why? > Source/WebKit2/WebProcess/Plugins/PluginProxy.messages.in:60 > + # Called when the plug-in's focus or it's containing window focus changes. Should be "its", not "it's".
Anders Carlsson
Comment 3 2011-08-22 14:26:52 PDT
(In reply to comment #2) > (From update of attachment 104737 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104737&action=review > > > Source/WebKit2/ChangeLog:3 > > + The UI process should keep track of whether a plug-in has focus or not > > Why? It's so we can implement the new Cocoa text input model. > > > Source/WebKit2/WebProcess/Plugins/PluginProxy.messages.in:60 > > + # Called when the plug-in's focus or it's containing window focus changes. > > Should be "its", not "it's". Fixed.
Darin Adler
Comment 4 2011-08-22 14:29:04 PDT
Comment on attachment 104737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104737&action=review >>> Source/WebKit2/ChangeLog:3 >>> + The UI process should keep track of whether a plug-in has focus or not >> >> Why? > > It's so we can implement the new Cocoa text input model. Is it OK that the information in the UI process could be out of date?
Anders Carlsson
Comment 5 2011-08-22 14:33:56 PDT
(In reply to comment #4) > (From update of attachment 104737 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104737&action=review > > >>> Source/WebKit2/ChangeLog:3 > >>> + The UI process should keep track of whether a plug-in has focus or not > >> > >> Why? > > > > It's so we can implement the new Cocoa text input model. > > Is it OK that the information in the UI process could be out of date? Yes.
Anders Carlsson
Comment 6 2011-08-22 14:35:28 PDT
Committed r93543: <http://trac.webkit.org/changeset/93543>
Note You need to log in before you can comment on or make changes to this bug.