|Summary:||[chromium] WebViewImpl should not reshape the 3D context|
|Product:||WebKit||Reporter:||Iain Merrick <husky>|
|Component:||New Bugs||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||husky, jamesr, nduca, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Iain Merrick 2011-08-22 13:17:12 PDT
This is now handled by the compositor. Reshapes need to be done on the compositor thread.
Comment 1 Iain Merrick 2011-08-22 13:19:13 PDT
Created attachment 104723 [details] Remove two reshape calls.
Comment 2 Nat Duca 2011-08-22 13:22:43 PDT
Comment on attachment 104723 [details] Remove two reshape calls. Looks good. Should probably "test" that things work still by (a) visiting a page with WebGL and making sure it works and then (b) killing the GPU process and making sure the page still recovers from lost context.
Comment 3 Iain Merrick 2011-08-22 17:08:16 PDT
I manually tested WebGL and about:gpucrash
Comment 4 WebKit Review Bot 2011-08-22 17:37:27 PDT
Comment on attachment 104723 [details] Remove two reshape calls. Clearing flags on attachment: 104723 Committed r93566: <http://trac.webkit.org/changeset/93566>
Comment 5 WebKit Review Bot 2011-08-22 17:37:31 PDT
All reviewed patches have been landed. Closing bug.