Bug 66700

Summary: [EFL] Add auxiliary history functions for DRT
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: leandro, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Raphael Kubo da Costa (:rakuco)
Reported 2011-08-22 12:19:56 PDT
[EFL] Add auxiliary history functions for DRT
Attachments
Patch (3.35 KB, patch)
2011-08-22 12:21 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Patch (3.43 KB, patch)
2011-08-23 05:24 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-08-22 12:21:18 PDT
Created attachment 104714 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2011-08-22 12:24:05 PDT
CC'ing tkent in this drt-related patch.
Kent Tamura
Comment 3 2011-08-22 18:41:04 PDT
Comment on attachment 104714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104714&action=review > Source/WebKit/efl/ewk/ewk_history.cpp:413 > + * Returns a newly-allocated string with the item's target name. Probably you had better provide information about - Callers should delete the allocated string - how to delete the allocated string because the users can't know the function is using strdup() without reading the source code.
Raphael Kubo da Costa (:rakuco)
Comment 4 2011-08-23 05:24:45 PDT
Created attachment 104826 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 5 2011-08-23 05:26:56 PDT
Oops, I ended up sending an updated patch after the cq+ was given, sorry :)
WebKit Review Bot
Comment 6 2011-08-23 06:37:52 PDT
Comment on attachment 104826 [details] Patch Clearing flags on attachment: 104826 Committed r93602: <http://trac.webkit.org/changeset/93602>
WebKit Review Bot
Comment 7 2011-08-23 06:37:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.