Summary: | [EFL] Implement FrameLoaderClient::didTransferChildFrameToNewDocument | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||||||
Component: | New Bugs | Assignee: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | leandro, tonikitoo, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Raphael Kubo da Costa (:rakuco)
2011-08-22 11:12:58 PDT
Created attachment 104699 [details]
Patch
tonikitoo, could you take a look at this one? Comment on attachment 104699 [details] Patch Rejecting attachment 104699 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: t/FrameLoaderClientEfl.cpp Hunk #1 succeeded at 362 (offset -4 lines). patching file Source/WebKit/efl/ewk/ewk_frame.cpp Hunk #1 succeeded at 1181 (offset 1 line). Hunk #2 succeeded at 1477 (offset 1 line). patching file Source/WebKit/efl/ewk/ewk_private.h Hunk #1 FAILED at 144. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_private.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Antonio Gomes', u'--fo..." exit_code: 1 Full output: http://queues.webkit.org/results/9510159 Created attachment 105172 [details]
Patch rebased on top of trunk
Created attachment 105217 [details]
Hardcode tonikitoo as the reviewer
Comment on attachment 105217 [details] Hardcode tonikitoo as the reviewer Clearing flags on attachment: 105217 Committed r93813: <http://trac.webkit.org/changeset/93813> All reviewed patches have been landed. Closing bug. |