Bug 66690

Summary: [EFL] Implement FrameLoaderClient::didTransferChildFrameToNewDocument
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: New BugsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: leandro, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch rebased on top of trunk
none
Hardcode tonikitoo as the reviewer none

Raphael Kubo da Costa (:rakuco)
Reported 2011-08-22 11:12:58 PDT
[EFL] Implement FrameLoaderClient::didTransferChildFrameToNewDocument
Attachments
Patch (4.37 KB, patch)
2011-08-22 11:15 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Patch rebased on top of trunk (4.42 KB, patch)
2011-08-25 06:40 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Hardcode tonikitoo as the reviewer (4.42 KB, patch)
2011-08-25 10:46 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2011-08-22 11:15:33 PDT
Created attachment 104699 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2011-08-22 11:16:47 PDT
tonikitoo, could you take a look at this one?
WebKit Review Bot
Comment 3 2011-08-24 19:57:19 PDT
Comment on attachment 104699 [details] Patch Rejecting attachment 104699 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: t/FrameLoaderClientEfl.cpp Hunk #1 succeeded at 362 (offset -4 lines). patching file Source/WebKit/efl/ewk/ewk_frame.cpp Hunk #1 succeeded at 1181 (offset 1 line). Hunk #2 succeeded at 1477 (offset 1 line). patching file Source/WebKit/efl/ewk/ewk_private.h Hunk #1 FAILED at 144. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_private.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Antonio Gomes', u'--fo..." exit_code: 1 Full output: http://queues.webkit.org/results/9510159
Raphael Kubo da Costa (:rakuco)
Comment 4 2011-08-25 06:40:07 PDT
Created attachment 105172 [details] Patch rebased on top of trunk
Raphael Kubo da Costa (:rakuco)
Comment 5 2011-08-25 10:46:10 PDT
Created attachment 105217 [details] Hardcode tonikitoo as the reviewer
WebKit Review Bot
Comment 6 2011-08-25 13:21:53 PDT
Comment on attachment 105217 [details] Hardcode tonikitoo as the reviewer Clearing flags on attachment: 105217 Committed r93813: <http://trac.webkit.org/changeset/93813>
WebKit Review Bot
Comment 7 2011-08-25 13:21:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.