Bug 66677

Summary: Web Inspector: generate protocol externs API for the front-end compilation.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch tonyg: review+

Description Pavel Feldman 2011-08-22 08:38:52 PDT 
Patch to follow.
Comment 1 Pavel Feldman 2011-08-22 09:10:41 PDT 
Created attachment 104683 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-22 09:15:09 PDT 
Attachment 104683 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1

Source/WebCore/inspector/InspectorDebuggerAgent.cpp:184:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorDebuggerAgent.h:85:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ilya Tikhonovsky 2011-08-23 02:04:37 PDT 
Comment on attachment 104683 [details]
Patch

lgtm
Comment 4 Tony Gentilcore 2011-08-23 02:24:58 PDT 
Comment on attachment 104683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104683&action=review

> Source/WebCore/inspector/compile-front-end.sh:1
> +python Source/WebCore/inspector/generate-protocol-externs -o Source/WebCore/inspector/front-end/protocol-externs.js Source/WebCore/inspector/Inspector.json

Should this file have a #! line and/or a copyright?
Comment 5 Pavel Feldman 2011-08-23 02:34:11 PDT 
Committed r93586: <http://trac.webkit.org/changeset/93586>