RESOLVED FIXED 66677
Web Inspector: generate protocol externs API for the front-end compilation. 
https://bugs.webkit.org/show_bug.cgi?id=66677
Summary Web Inspector: generate protocol externs API for the front-end compilation.
Pavel Feldman
Reported 2011-08-22 08:38:52 PDT
Patch to follow.
Attachments
Patch (13.58 KB, patch)
2011-08-22 09:10 PDT, Pavel Feldman 		tonyg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-08-22 09:10:41 PDT
Created attachment 104683 [details] Patch
WebKit Review Bot
Comment 2 2011-08-22 09:15:09 PDT
Attachment 104683 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1 Source/WebCore/inspector/InspectorDebuggerAgent.cpp:184: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorDebuggerAgent.h:85: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ilya Tikhonovsky
Comment 3 2011-08-23 02:04:37 PDT
Comment on attachment 104683 [details] Patch lgtm
Tony Gentilcore
Comment 4 2011-08-23 02:24:58 PDT
Comment on attachment 104683 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104683&action=review > Source/WebCore/inspector/compile-front-end.sh:1 > +python Source/WebCore/inspector/generate-protocol-externs -o Source/WebCore/inspector/front-end/protocol-externs.js Source/WebCore/inspector/Inspector.json Should this file have a #! line and/or a copyright?
Pavel Feldman
Comment 5 2011-08-23 02:34:11 PDT
Committed r93586: <http://trac.webkit.org/changeset/93586>
Note You need to log in before you can comment on or make changes to this bug.