Summary: | [Qt][WK2] ViewportInteractionEngine: the position of the content is not corrected when scaling the page manually | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
Component: | WebKit2 | Assignee: | Benjamin Poulain <benjamin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | kenneth | ||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Benjamin Poulain
2011-08-22 07:10:54 PDT
Created attachment 104674 [details]
Patch
Comment on attachment 104674 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104674&action=review > Source/WebKit2/ChangeLog:9 > + This method is now used as the entry point for animations in order to avoid bugs of scale or position. s/of/regarding > Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp:254 > + animateContentScaleIntoBoundariesIfNeeded(); > + animateContentPositionIntoBoundariesIfNeeded(); Shouldn't they be animated together? (In reply to comment #2) > s/of/regarding > > > Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp:254 > > + animateContentScaleIntoBoundariesIfNeeded(); > > + animateContentPositionIntoBoundariesIfNeeded(); > > Shouldn't they be animated together? I think QParallelAnimationGroup will do the trick. I will try to keep the methods separated even if they must have a common animation, just for the sake of keeping the code clean. Committed r93592: <http://trac.webkit.org/changeset/93592> |