Bug 66672

Summary:

[Qt][WK2] ViewportInteractionEngine: the position of the content is not corrected when scaling the page manually

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

WebKit2

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kenneth

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kenneth: review+

Description Benjamin Poulain 2011-08-22 07:10:54 PDT

When zooming, both the position and the scale needs to come back to the boundary.

Comment 1 Benjamin Poulain 2011-08-22 07:16:13 PDT

Created attachment 104674 [details]
Patch

Comment 2 Kenneth Rohde Christiansen 2011-08-22 07:21:29 PDT

Comment on attachment 104674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104674&action=review

> Source/WebKit2/ChangeLog:9
> +        This method is now used as the entry point for animations in order to avoid bugs of scale or position.

s/of/regarding

> Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp:254
> +    animateContentScaleIntoBoundariesIfNeeded();
> +    animateContentPositionIntoBoundariesIfNeeded();

Shouldn't they be animated together?

Comment 3 Benjamin Poulain 2011-08-22 07:36:57 PDT

(In reply to comment #2)
> s/of/regarding
> 
> > Source/WebKit2/UIProcess/qt/ViewportInteractionEngine.cpp:254
> > +    animateContentScaleIntoBoundariesIfNeeded();
> > +    animateContentPositionIntoBoundariesIfNeeded();
> 
> Shouldn't they be animated together?

I think QParallelAnimationGroup will do the trick. I will try to keep the methods separated even if they must have a common animation, just for the sake of keeping the code clean.

Comment 4 Benjamin Poulain 2011-08-23 05:39:40 PDT

Committed r93592: <http://trac.webkit.org/changeset/93592>