| Summary: | Text overlaps with the floats | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexandru Chiculita <achicu> | ||||||||||||
| Component: | Layout and Rendering | Assignee: | Alexandru Chiculita <achicu> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | dglazkov, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 104811 [details]
Patch V1
Created attachment 104820 [details]
Patch V2
Moved expected results to mac platform.
Comment on attachment 104820 [details] Patch V2 Attachment 104820 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9478294 New failing tests: fast/block/float/fit_line_below_floats.html Created attachment 104824 [details]
Patch V4
Added test_expectations
Created attachment 104827 [details]
Patch V5
Fixed comment style in Skipped files.
Comment on attachment 104827 [details]
Patch V5
r=me
Comment on attachment 104827 [details] Patch V5 Clearing flags on attachment: 104827 Committed r93628: <http://trac.webkit.org/changeset/93628> All reviewed patches have been landed. Closing bug. |
Created attachment 104671 [details] Test case The problem is that LineWidth::fitBelowFloats is not updating the m_left and m_right fields. Next time LineWidth::shrinkAvailableWidthForNewFloatIfNeeded is called the width is recalculated, with the old values. See the attached test case for more info.