Summary: | [Qt] Button text is invisible when mobile theme is in use and application palette set to use light text color. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Misha <mtutunik> | ||||||||
Component: | New Bugs | Assignee: | Misha <mtutunik> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | kling, webkit.review.bot | ||||||||
Priority: | P3 | Keywords: | Qt | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Misha
2011-08-21 16:15:30 PDT
Created attachment 104631 [details]
proposed patch.
Calling setPaletteFromPageClientIfExists() takes care about the issue.
Comment on attachment 104631 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=104631&action=review LGTM. It's a shame we don't test the mobile theme on the bots, though. > Source/WebCore/ChangeLog:7 > + When mobile theme is in use and application pallete is using light pallete -> palette > Source/WebCore/ChangeLog:8 > + color to display text button text become invisible. The reason for "text button text become" -> "text, button text becomes" > Source/WebCore/ChangeLog:10 > + pallete while when are painting button lightGrayPalette is used. pallete -> palette "when are painting button" -> "when we are painting buttons" > Source/WebCore/ChangeLog:11 > + Calling setPaletteFromPageClientIfExists() takes care about the issue. about -> of Created attachment 104717 [details]
patch with corrected change log
Comment on attachment 104717 [details]
patch with corrected change log
This changelog is missing the Reviewed by part.
Created attachment 104890 [details]
Corrected Change log again
Comment on attachment 104890 [details] Corrected Change log again Clearing flags on attachment: 104890 Committed r93652: <http://trac.webkit.org/changeset/93652> All reviewed patches have been landed. Closing bug. |