Bug 66629

Summary:

Remove ATS code in favor of CGFont in FontCustomPlatformData.cpp

Product:

WebKit

Reporter:

Jeremy Moskovich <playmobil>

Component:

WebCore Misc.

Assignee:

Jeremy Moskovich <playmobil>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

ahmad.saleem792, ap, bfulgham, dglazkov, eric, mitz, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

66933

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Jeremy Moskovich

Reported 2011-08-21 04:41:40 PDT

As of r72774 and dropping support for OS X 10.4, we can safely remove the ATS APIs from FontCustomPlatformData.cpp in favor of just the CGFont code. This change is motivated by a bug in ATSFontDeactivite() on 10.7 which affects the Chromium port, due to it's compiling once against the 10.5 SDK for all platforms - See crbug.com/93191 or rdar://9976774 .

Attachments
Patch (5.12 KB, patch) 2011-08-21 04:45 PDT, Jeremy Moskovich	no flags	Details Formatted Diff Diff
Patch for landing (5.07 KB, patch) 2011-08-25 02:19 PDT, Jeremy Moskovich	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jeremy Moskovich

Comment 1 2011-08-21 04:45:48 PDT

Created attachment 104625 [details] Patch

mitz

Comment 2 2011-08-21 18:18:29 PDT

Comment on attachment 104625 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104625&action=review > Source/WebCore/ChangeLog:6 > + As of r72774 and dropping support for OS X 10.4, we can safely Extra space after the comma > Source/WebCore/ChangeLog:11 > + affects the Chromium port, due to it's compiling once against the 10.5 Typo: it's

Jeremy Moskovich

Comment 3 2011-08-25 02:19:11 PDT

Created attachment 105147 [details] Patch for landing

WebKit Review Bot

Comment 4 2011-08-25 03:19:10 PDT

Comment on attachment 105147 [details] Patch for landing Clearing flags on attachment: 105147 Committed r93771: <http://trac.webkit.org/changeset/93771>

WebKit Review Bot

Comment 5 2011-08-25 03:19:14 PDT

All reviewed patches have been landed. Closing bug.

Jeremy Moskovich

Comment 6 2011-08-25 06:01:55 PDT

Rolled back the patch since it's causing css3/font-feature-settings-rendering.html to crash on 10.5, need to investigate.

Ahmad Saleem

Comment 7 2022-09-24 05:38:02 PDT

I am not able to find any code with "ATSFontFindFromContainer" and other bits. I think this got removed some time later. Can we mark this close, if we don't need this now? Thanks!

Brent Fulgham

Comment 8 2022-09-26 11:33:11 PDT

This code was removed long ago.

Note You need to log in before you can comment on or make changes to this bug.