Bug 66614

Summary: Chromium Mac: Add fallback for drawing PDF overhang area
Product: WebKit Reporter: Sailesh Agrawal <sail>
Component: New BugsAssignee: Sailesh Agrawal <sail>
Status: RESOLVED FIXED    
Severity: Normal CC: asvitkine, dglazkov, fishd, jam, thakis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Sailesh Agrawal
Reported 2011-08-19 17:59:24 PDT
Chromium Mac: Add fallback for drawing PDF overhang area
Attachments
Patch (6.54 KB, patch)
2011-08-19 18:02 PDT, Sailesh Agrawal 		no flags
DetailsFormatted DiffDiff
Patch (6.54 KB, patch)
2011-08-19 18:07 PDT, Sailesh Agrawal 		no flags
DetailsFormatted DiffDiff
Patch (4.98 KB, patch)
2011-08-21 09:44 PDT, Sailesh Agrawal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sailesh Agrawal
Comment 1 2011-08-19 18:02:14 PDT
Created attachment 104604 [details] Patch
Sailesh Agrawal
Comment 2 2011-08-19 18:03:52 PDT
This is a temporary work around for the following chromium bug: http://code.google.com/p/chromium/issues/detail?id=92923
WebKit Review Bot
Comment 3 2011-08-19 18:05:33 PDT
Comment on attachment 104604 [details] Patch Attachment 104604 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9438550
Sailesh Agrawal
Comment 4 2011-08-19 18:07:34 PDT
Created attachment 104605 [details] Patch
Nico Weber
Comment 5 2011-08-19 21:30:54 PDT
Alexei, does this make sense to you?
Darin Fisher (:fishd, Google)
Comment 6 2011-08-19 22:23:21 PDT
Comment on attachment 104605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104605&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:2398 > + Frame* frame = mainFrameImpl()->frame(); is there any advantage to having this code live here in WebViewImpl? why not just put this directly in ChromeClientImpl.cpp?
Sailesh Agrawal
Comment 7 2011-08-21 09:44:58 PDT
Created attachment 104629 [details] Patch
Sailesh Agrawal
Comment 8 2011-08-21 09:45:35 PDT
Comment on attachment 104605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104605&action=review >> Source/WebKit/chromium/src/WebViewImpl.cpp:2398 >> + Frame* frame = mainFrameImpl()->frame(); > > is there any advantage to having this code live here in WebViewImpl? > why not just put this directly in ChromeClientImpl.cpp? Fixed. Moved to ChromeClientImpl.cpp.
asvitkine
Comment 9 2011-08-21 12:35:55 PDT
(In reply to comment #5) > Alexei, does this make sense to you? LGTM
Sailesh Agrawal
Comment 10 2011-08-24 11:25:02 PDT
Ping!
WebKit Review Bot
Comment 11 2011-08-31 15:39:10 PDT
Comment on attachment 104629 [details] Patch Clearing flags on attachment: 104629 Committed r94240: <http://trac.webkit.org/changeset/94240>
WebKit Review Bot
Comment 12 2011-08-31 15:39:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.