Summary: | Implement ExecutableAllocator::cacheFlush() for QNX | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||||
Component: | JavaScriptCore | Assignee: | Daniel Bates <dbates> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Daniel Bates
2011-08-19 17:10:01 PDT
Created attachment 104598 [details]
Patch
Attachment 104598 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/jit/ExecutableAllocator.h:43: "sys/mman.h" already included at Source/JavaScriptCore/jit/ExecutableAllocator.h:39 [build/include] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 104600 [details]
Patch
Comment on attachment 104600 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104600&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.h:337 > + static void cacheFlush(void* code, size_t size) > + { > +#if !ENABLE(ASSEMBLER_WX_EXCLUSIVE) > + msync(code, size, MS_INVALIDATE_ICACHE); > +#endif > + } Looks like you’d get an unused variable warning if ENABLE(ASSEMBLER_WX_EXCLUSIVE) was true. (In reply to comment #4) > (From update of attachment 104600 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104600&action=review > > > Source/JavaScriptCore/jit/ExecutableAllocator.h:337 > > + static void cacheFlush(void* code, size_t size) > > + { > > +#if !ENABLE(ASSEMBLER_WX_EXCLUSIVE) > > + msync(code, size, MS_INVALIDATE_ICACHE); > > +#endif > > + } > > Looks like you’d get an unused variable warning if ENABLE(ASSEMBLER_WX_EXCLUSIVE) was true. Will fix. Created attachment 104602 [details]
Patch
Comment on attachment 104602 [details] Patch Clearing flags on attachment: 104602 Committed r93462: <http://trac.webkit.org/changeset/93462> All reviewed patches have been landed. Closing bug. |