Bug 66583

Summary: [Qt] unnecessary folders in webkit2
Product: WebKit Reporter: Gopal Raghavan <gopal.1.raghavan>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: jturcotte, kling, webkit.review.bot
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
remove empty folders
none
remove empty folders noam: review+, kling: commit-queue-

Description Gopal Raghavan 2011-08-19 13:57:25 PDT 
Probably left over from past implementation of graphicswkview
Comment 1 Gopal Raghavan 2011-08-23 12:40:04 PDT 
Created attachment 104892 [details]
remove empty folders
Comment 2 WebKit Review Bot 2011-08-23 12:43:11 PDT 
Attachment 104892 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog']" exit_code: 1

Source/WebKit2/ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gopal Raghavan 2011-08-23 12:48:32 PDT 
Created attachment 104893 [details]
remove empty folders
Comment 4 Alexis Menard (darktears) 2011-08-23 12:50:02 PDT 
Comment on attachment 104893 [details]
remove empty folders

LGTM :D
Comment 5 Jocelyn Turcotte 2011-08-23 13:00:09 PDT 
The folders were already removed in trunk, make sure you generate your ChangeLog on master after cherry-picking and not on a branch to prevent this.
Comment 6 Gopal Raghavan 2011-08-23 13:24:15 PDT 
folders and still there on trunk. I have svn trunk checked out. I am not on a branch. It's also visible here http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/API/qt/tests
Comment 7 Andreas Kling 2011-08-23 13:49:03 PDT 
Committed r93636: <http://trac.webkit.org/changeset/93636>
Comment 8 Andreas Kling 2011-08-23 13:49:49 PDT 
Comment on attachment 104893 [details]
remove empty folders

This patch won't do anything via CQ as there's nothing telling it to remove the folders. I removed the folders directly using svn.
Comment 9 Gopal Raghavan 2011-08-23 14:02:56 PDT 
Thanks.
For some reason svn-create-patch didn't pick this up. Looks like svn diff on empty folders don't listing them either. Anyway, thanks for manually removing it.