Summary: | editing/selection/caret-at-bidi-boundary.html timing out on Windows since it was added | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||||
Component: | Tools / Tests | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hyatt, mrobinson, rniwa, webkit.review.bot | ||||||
Priority: | P2 | Keywords: | LayoutTestFailure, PlatformOnly | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows 7 | ||||||||
URL: | http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r93369%20(15625)/results.html | ||||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-08-19 05:55:44 PDT
Does the test still time out if you commented out all but the first dt and dd? So the problem is that Windows port's DRT actually sleeps for the amount of time leapForward is called upon :( See replaySavedEvents in win/EventSender.cpp. This is not now other ports implement leapForward. Skipped the test in http://trac.webkit.org/changeset/93464. (In reply to comment #3) > So the problem is that Windows port's DRT actually sleeps for the amount of time leapForward is called upon :( See replaySavedEvents in win/EventSender.cpp. This is not now other ports implement leapForward. I'm not sure this is accurate. GTK+, Qt and Windows all implement leapForward this way. Created attachment 104703 [details]
fixes the test
Created attachment 104704 [details]
fixed the tab
Attachment 104703 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/edit..." exit_code: 1
LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Note I have verified that the test passes on Windows after this change. Committed r93529: <http://trac.webkit.org/changeset/93529> |