Bug 66549

Summary: [Qt][WK2] Change the rect argument of QtWebPageProxy::paint() to const ref
Product: WebKit Reporter: Lars Knudsen <larsgk>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, kling, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
change arg to const ref
none
Patch
none
Patch none

Lars Knudsen
Reported 2011-08-19 05:51:24 PDT
SSIA
Attachments
change arg to const ref (1.67 KB, patch)
2011-08-19 06:02 PDT, Lars Knudsen 		no flags
DetailsFormatted DiffDiff
Patch (1.93 KB, patch)
2011-08-19 06:22 PDT, Lars Knudsen 		no flags
DetailsFormatted DiffDiff
Patch (1.93 KB, patch)
2011-08-19 06:32 PDT, Lars Knudsen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Lars Knudsen
Comment 1 2011-08-19 06:02:37 PDT
Created attachment 104495 [details] change arg to const ref
Benjamin Poulain
Comment 2 2011-08-19 06:07:09 PDT
Comment on attachment 104495 [details] change arg to const ref View in context: https://bugs.webkit.org/attachment.cgi?id=104495&action=review You should use webkit-patch for uploading patches. I reject for the changelog and educational purpose :) > Source/WebKit2/ChangeLog:3 > + Changed argument to const ref. I updated the title, please update the changelog accordingly.
Lars Knudsen
Comment 3 2011-08-19 06:22:37 PDT
Created attachment 104502 [details] Patch
Benjamin Poulain
Comment 4 2011-08-19 06:23:46 PDT
Comment on attachment 104502 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104502&action=review > Source/WebKit2/ChangeLog:3 > + [Qt][WK2] Change the rect argument of QtWebPageProxy::paint() to to const ref Oops, sorry, I did a typo in the title.
Lars Knudsen
Comment 5 2011-08-19 06:32:33 PDT
Created attachment 104505 [details] Patch
WebKit Review Bot
Comment 6 2011-08-19 07:46:27 PDT
Comment on attachment 104505 [details] Patch Clearing flags on attachment: 104505 Committed r93402: <http://trac.webkit.org/changeset/93402>
WebKit Review Bot
Comment 7 2011-08-19 07:46:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.