Bug 66534

Summary: Switch RenderBoxModelObject to to new layout types
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, leviw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63567    
Attachments:
Description Flags
Patch
none
Patch for landing none

Emil A Eklund
Reported 2011-08-18 21:17:35 PDT
Convert RenderBoxModelObject to new layout abstraction.
Attachments
Patch (37.50 KB, patch)
2011-08-18 21:38 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (37.25 KB, patch)
2011-08-19 12:00 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2011-08-18 21:38:06 PDT
Created attachment 104456 [details] Patch
WebKit Review Bot
Comment 2 2011-08-18 22:10:28 PDT
Comment on attachment 104456 [details] Patch Attachment 104456 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9436074 New failing tests: fast/backgrounds/gradient-background-leakage.html
Eric Seidel (no email)
Comment 3 2011-08-19 00:57:32 PDT
Comment on attachment 104456 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104456&action=review Otherwise looks OK. > Source/WebCore/rendering/RenderBoxModelObject.cpp:590 > - FloatSize contextScale(static_cast<float>(ctm.xScale()), static_cast<float>(ctm.yScale())); > + FloatSize contextScale(static_cast<LayoutUnit>(ctm.xScale()), static_cast<LayoutUnit>(ctm.yScale())); LayoutUnit is currently an int, no?
Emil A Eklund
Comment 4 2011-08-19 12:00:30 PDT
Created attachment 104541 [details] Patch for landing
WebKit Review Bot
Comment 5 2011-08-19 13:41:12 PDT
Comment on attachment 104541 [details] Patch for landing Clearing flags on attachment: 104541 Committed r93435: <http://trac.webkit.org/changeset/93435>
WebKit Review Bot
Comment 6 2011-08-19 13:41:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.