Bug 66524

Summary: Test how HTMLButtonElement.setCustomValidity reacts to too few arguments
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, mjs, sam, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66235    
Attachments:
Description Flags
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2011-08-18 19:59:48 PDT
Test how HTMLButtonElement.setCustomValidity reacts to too few arguments
Attachments
Patch (2.12 KB, patch)
2011-08-18 20:00 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (2.66 KB, patch)
2011-11-29 11:23 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2011-08-18 20:00:57 PDT
Created attachment 104441 [details] Patch
Kent Tamura
Comment 2 2011-08-18 22:29:01 PDT
Existing setCustomValidity-related tests are in LayoutTests/fast/forms/. Would you merge this, Bug 66525, and Bug 66526 into one test, and move it to fast/forms/ please?
Adam Barth
Comment 3 2011-09-03 14:24:57 PDT
Comment on attachment 104441 [details] Patch I agree with Darin. Having a separate test for each of these functions is kind of overkill. Can we combine them into one (or a few) tests that exercise groups of related APIs. For example, it seems like all the setCustomValidity tests would be better combined into a single test.
Mark Pilgrim (Google)
Comment 4 2011-11-29 11:23:13 PST
Created attachment 117006 [details] Patch
Mark Pilgrim (Google)
Comment 5 2011-11-29 11:23:42 PST
*** Bug 66528 has been marked as a duplicate of this bug. ***
Mark Pilgrim (Google)
Comment 6 2011-11-29 11:23:51 PST
*** Bug 66526 has been marked as a duplicate of this bug. ***
Mark Pilgrim (Google)
Comment 7 2011-11-29 11:24:06 PST
*** Bug 66525 has been marked as a duplicate of this bug. ***
Mark Pilgrim (Google)
Comment 8 2011-11-29 11:24:29 PST
Reopening with fresh patch.
WebKit Review Bot
Comment 9 2011-11-30 03:23:07 PST
Comment on attachment 117006 [details] Patch Clearing flags on attachment: 117006 Committed r101478: <http://trac.webkit.org/changeset/101478>
WebKit Review Bot
Comment 10 2011-11-30 03:23:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.