Summary: | [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dmitry Lomov <dslomov> | ||||||||||||||
Component: | WebCore Misc. | Assignee: | Dmitry Lomov <dslomov> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | dglazkov, dimich, fishd, jam, levin, levin+threading, rniwa, tkent, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Bug Depends on: | 61016, 75278, 75332 | ||||||||||||||||
Bug Blocks: | |||||||||||||||||
Attachments: |
|
Description
Dmitry Lomov
2011-08-18 16:21:57 PDT
Created attachment 120377 [details]
The fix
The patch looks massive but conceptually it is very simple - see ChangeLog for an overview
Comment on attachment 120377 [details] The fix Attachment 120377 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10962039 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. Created attachment 120395 [details]
DumpRenderTree fixed
Comment on attachment 120395 [details]
DumpRenderTree fixed
WebKit API changes LGTM... probably should get levin / dimich / jianli to review the rest.
Comment on attachment 120395 [details] DumpRenderTree fixed View in context: https://bugs.webkit.org/attachment.cgi?id=120395&action=review > Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:45 > + No need for blank line here. > Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:55 > + No need for blank line here. (Just sort all of these together.) > Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:59 > +#include <wtf/MainThread.h> <wtf/... should be after other header includes. > Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:61 > #include "WorkerDebuggerAgent.h" Should be with the other #include's. > Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp:162 > + PassOwnPtr<MessagePortChannelArray> channels) indent off. (in many places in this file). Created attachment 120402 [details]
CR feedback
Created attachment 120405 [details]
CR feedback
Comment on attachment 120405 [details] CR feedback Clearing flags on attachment: 120405 Committed r103619: <http://trac.webkit.org/changeset/103619> All reviewed patches have been landed. Closing bug. This broke Linux clang builds: In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/AccessibilityController.cpp:34: In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43: third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*); ^ third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; } ^ 1 error generated. make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/AccessibilityController.o] Error 1 In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:33: In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43: third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*); ^ third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; } ^ 1 error generated. make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/DumpRenderTree.o] Error 1 In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/EventSender.cpp:46: In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43: third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*); ^ third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; } ^ 1 error generated. make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/EventSender.o] Error 1 In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/GamepadController.cpp:34: In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43: third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*); ^ third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; } ^ 1 error generated. make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/GamepadController.o] Error 1 In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/PlainTextController.cpp:35: In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43: third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*); ^ third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; } ^ 1 error generated. make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/PlainTextController.o] Error 1 In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/LayoutTestController.cpp:36: In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43: third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*); ^ third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; } ^ 1 error generated. make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/LayoutTestController.o] Error 1 In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestNavigationController.cpp:34: In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43: third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*); ^ third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; } ^ 1 error generated. make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/TestNavigationController.o] Error 1 In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.cpp:32: In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43: third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*); ^ third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; } ^ 1 error generated. make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.o] Error 1 In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShellGtk.cpp:32: In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43: third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*); ^ third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; } ^ 1 error generated. make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/TestShellGtk.o] Error 1 In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.cpp:32: third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*); ^ third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; } ^ 1 error generated. make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.o] Error 1 In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/WebPermissions.cpp:35: In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43: third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*); ^ third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; } ^ 1 error generated. make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/WebPermissions.o] Error 1 In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TextInputController.cpp:34: In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43: third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*); ^ third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; } ^ 1 error generated. make: *** [out/Debug/obj.target/DumpRenderTree/third_party/WebKit/Tools/DumpRenderTree/chromium/TextInputController.o] Error 1 In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShellLinux.cpp:32: In file included from third_party/WebKit/Tools/DumpRenderTree/chromium/TestShell.h:43: third_party/WebKit/Tools/DumpRenderTree/chromium/WebViewHost.h:177:32: error: 'WebViewHost::createWorker' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual WebKit::WebWorker* createWorker(WebKit::WebFrame*, WebKit::WebSharedWorkerClient*); ^ third_party/WebKit/Source/WebKit/chromium/public/WebFrameClient.h:86:24: note: hidden overloaded virtual function 'WebKit::WebFrameClient::createWorker' declared here virtual WebWorker* createWorker(WebFrame*, WebWorkerClient*) { return 0; } ^ 1 error generated. Reopen the bug since the patch was rolled out in http://trac.webkit.org/changeset/103658 per IRC discussion with Dmitry. (In reply to comment #12) > Reopen the bug since the patch was rolled out in http://trac.webkit.org/changeset/103658 per IRC discussion with Dmitry. Thanks Ryosuke, will fix and reland. Created attachment 120702 [details]
Reuploading the patch to use cq to commit.
Will probably need to clobber builders
Created attachment 120704 [details]
Missing file
Comment on attachment 120704 [details] Missing file Clearing flags on attachment: 120704 Committed r103785: <http://trac.webkit.org/changeset/103785> All reviewed patches have been landed. Closing bug. Patch broke build... Trying to figure out why... Patch landed in http://trac.webkit.org/changeset/103789 |