Bug 66499

Summary: Rename VisiblePosition::honorEditableBoundary* to VisiblePosition::honorEditingBoundary*
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cshu, darin, justin.garcia, leviw, vanlam, webkit.review.bot, xji
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Revised patch
none
Revised patch none

Description Ryosuke Niwa 2011-08-18 14:40:27 PDT 
The following member functions of VisiblePosition use the non-standard term edit*able* boundary.  We should rename these functions to use edit*ing* boundary for consistency.
VisiblePosition honorEditableBoundaryAtOrBefore(const VisiblePosition&) const;
VisiblePosition honorEditableBoundaryAtOrAfter(const VisiblePosition&) const;
Comment 1 Van Lam 2011-08-19 10:39:44 PDT 
Created attachment 104524 [details]
Patch
Comment 2 Ryosuke Niwa 2011-08-19 10:47:11 PDT 
Comment on attachment 104524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104524&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

Nit: you should remove this line.
Comment 3 Van Lam 2011-08-19 13:50:59 PDT 
Created attachment 104558 [details]
Revised patch

Removed the "no new tests" line from changelog.
Comment 4 Van Lam 2011-08-19 14:03:40 PDT 
Created attachment 104561 [details]
Revised patch

Fixed changelog.
Comment 5 WebKit Review Bot 2011-08-19 15:20:32 PDT 
Comment on attachment 104561 [details]
Revised patch

Clearing flags on attachment: 104561

Committed r93443: <http://trac.webkit.org/changeset/93443>
Comment 6 WebKit Review Bot 2011-08-19 15:20:37 PDT 
All reviewed patches have been landed.  Closing bug.