| Summary: | add embedded png checksums to WebKitTestRunner | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||
| Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tony Chang
2011-08-18 12:42:47 PDT
Created attachment 104385 [details]
Patch
Comment on attachment 104385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104385&action=review > Tools/WebKitTestRunner/CyclicRedundancyCheck.cpp:59 > + unsigned crc = 0xffffffffL; I know this is just copied code, but I should point out that this is wrong. If we want an unsigned constant it should be 0xffffffffU. Adding the "L" prefix makes it a long, so the type should be "long", not "unsigned". > Tools/WebKitTestRunner/CyclicRedundancyCheck.cpp:61 > + crc = crcTable[(crc ^ buffer[i]) & 0xff] ^ ((crc >> 8) & 0x00ffffffL); The L is not helpful. A U would be helpful. > Tools/WebKitTestRunner/CyclicRedundancyCheck.cpp:62 > + return crc ^ 0xffffffffL; The L is not helpful. A U would be helpful. Created attachment 104395 [details]
Patch for landing
Comment on attachment 104395 [details] Patch for landing Clearing flags on attachment: 104395 Committed r93355: <http://trac.webkit.org/changeset/93355> All reviewed patches have been landed. Closing bug. |