Bug 66486

Summary: "Could not find apache" reported even though apache is found
Product: WebKit Reporter: Tom Zakrajsek <tomz>
Component: Tools / TestsAssignee: Tom Zakrajsek <tomz>
Status: RESOLVED FIXED    
Severity: Normal CC: jchaffraix, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tom Zakrajsek
Reported 2011-08-18 11:09:25 PDT
In Tools/Scripts/webkitpy/layout_tests/port/webkit.py, there is a problem in _path_to_apache. The error message is inside the loop so it prints unless the first path is the right one. Fix is simple. Outdent _log.error one level.
Attachments
Patch (1.17 KB, patch)
2011-08-18 11:21 PDT, Tom Zakrajsek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tom Zakrajsek
Comment 1 2011-08-18 11:21:35 PDT
Created attachment 104369 [details] Patch
Ryosuke Niwa
Comment 2 2011-08-18 11:26:30 PDT
Comment on attachment 104369 [details] Patch this looks like a no-brainer so r=me.
WebKit Review Bot
Comment 3 2011-08-19 09:07:02 PDT
Comment on attachment 104369 [details] Patch Clearing flags on attachment: 104369 Committed r93416: <http://trac.webkit.org/changeset/93416>
WebKit Review Bot
Comment 4 2011-08-19 09:07:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.