| Summary: | IDBSQLiteBackingStore::deleteObjectStore should maintain referential integrity | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | jochen | ||||||
| Component: | New Bugs | Assignee: | jochen | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dgrogan, hans, tonyg, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
jochen
2011-08-18 08:20:06 PDT
Created attachment 104345 [details]
Patch
I had difficulty parsing the bug title, so re-titling for others' benefit. Please correct it if I misunderstood something. no, you're right. thanks for updating the title Created attachment 104364 [details]
Patch
LGTM Was sqlite returning an error because the references would be broken? (In reply to comment #5) > LGTM > > Was sqlite returning an error because the references would be broken? I don't know, it just occurred to me while working on that file that this is broken. doDelete doesn't do error checking :( and I think we don't check that code at all, as the layoutTests are executed with the leveldb backend afaik double-:( Comment on attachment 104364 [details] Patch Clearing flags on attachment: 104364 Committed r93395: <http://trac.webkit.org/changeset/93395> All reviewed patches have been landed. Closing bug. |