Bug 66470

Summary: IDBSQLiteBackingStore::deleteObjectStore should maintain referential integrity
Product: WebKit Reporter: jochen
Component: New BugsAssignee: jochen
Status: RESOLVED FIXED    
Severity: Normal CC: dgrogan, hans, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

jochen
Reported 2011-08-18 08:20:06 PDT
Delete object store data while maintaining referential integrity
Attachments
Patch (1.76 KB, patch)
2011-08-18 08:20 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Patch (1.78 KB, patch)
2011-08-18 10:53 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2011-08-18 08:20:26 PDT
Created attachment 104345 [details] Patch
Alexey Proskuryakov
Comment 2 2011-08-18 10:37:57 PDT
I had difficulty parsing the bug title, so re-titling for others' benefit. Please correct it if I misunderstood something.
jochen
Comment 3 2011-08-18 10:51:59 PDT
no, you're right. thanks for updating the title
jochen
Comment 4 2011-08-18 10:53:47 PDT
Created attachment 104364 [details] Patch
David Grogan
Comment 5 2011-08-18 11:34:03 PDT
LGTM Was sqlite returning an error because the references would be broken?
jochen
Comment 6 2011-08-18 11:37:01 PDT
(In reply to comment #5) > LGTM > > Was sqlite returning an error because the references would be broken? I don't know, it just occurred to me while working on that file that this is broken. doDelete doesn't do error checking :( and I think we don't check that code at all, as the layoutTests are executed with the leveldb backend afaik double-:(
WebKit Review Bot
Comment 7 2011-08-19 05:13:34 PDT
Comment on attachment 104364 [details] Patch Clearing flags on attachment: 104364 Committed r93395: <http://trac.webkit.org/changeset/93395>
WebKit Review Bot
Comment 8 2011-08-19 05:13:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.