Summary: | BORDER attribute percent with the input image tag not working. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihnea Ovidenie <mihnea> | ||||||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | dglazkov, simon.fraser, tabatkins, webkit.review.bot, zoltan | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Mihnea Ovidenie
2011-08-18 07:18:26 PDT
Created attachment 104341 [details]
Patch
Comment on attachment 104341 [details] Patch Attachment 104341 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9424635 New failing tests: fast/dom/HTMLInputElement/input-image-alt-text.html Created attachment 104485 [details]
Patch 2
Mark the test: fast/dom/HTMLInputElement/input-image-alt-text.html as failing in Chromium since its expectations must be regenerated.
Comment on attachment 104485 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=104485&action=review > Source/WebCore/ChangeLog:9 > + An image input element takes border attribute into account. > + If percent is specified in the border attribute, that percent is ignored. This doesn't really tell me what the original problem was, and how you fixed it. Created attachment 105953 [details]
Patch 3
Reworked changelog explanation for the patch.
Comment on attachment 105953 [details] Patch 3 Rejecting attachment 105953 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: es a/LayoutTests/platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png and b/LayoutTests/platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png differ". Be sure to use the --binary flag when invoking "git diff" with diffs containing binary files. at /mnt/git/webkit-commit-queue/Tools/Scripts/VCSUtils.pm line 668, <ARGV> line 97. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Simon Fraser', u'--for..." exit_code: 9 Full output: http://queues.webkit.org/results/9580286 Created attachment 106106 [details]
Patch 4
Forgot to add the binary image in the prev patch.
Comment on attachment 106106 [details] Patch 4 Clearing flags on attachment: 106106 Committed r94425: <http://trac.webkit.org/changeset/94425> All reviewed patches have been landed. Closing bug. Qt specific result has been landed in http://trac.webkit.org/changeset/94523. |