Bug 66436

Summary: --webkit-visual-word renaming right/leftWordPositionAcrossBoundary
Product: WebKit Reporter: Xiaomei Ji <xji>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, rniwa, vanlam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 25298    
Attachments:
Description Flags
patch
rniwa: review-
patch rniwa: review+

Xiaomei Ji
Reported 2011-08-17 17:29:12 PDT
Those 2 function names are confusing. They are actually returning right/left word position ignore editable boundary. Rename them to right/leftWordPositionIgnoreEditableBoundary.
Attachments
patch (2.62 KB, patch)
2011-08-17 18:09 PDT, Xiaomei Ji 		rniwa: review-
DetailsFormatted DiffDiff
patch (2.63 KB, patch)
2011-08-18 14:55 PDT, Xiaomei Ji 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xiaomei Ji
Comment 1 2011-08-17 18:09:21 PDT
Created attachment 104289 [details] patch
Ryosuke Niwa
Comment 2 2011-08-17 20:23:31 PDT
Comment on attachment 104289 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=104289&action=review > Source/WebCore/editing/visible_units.cpp:1598 > +static VisiblePosition leftWordPositionIgnoreEditableBoundary(const VisiblePosition& visiblePosition) We normally use AcrossEditingBoundary instead of IgnoringEditingBoundary.
Xiaomei Ji
Comment 3 2011-08-18 09:26:33 PDT
(In reply to comment #2) > (From update of attachment 104289 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104289&action=review > > > Source/WebCore/editing/visible_units.cpp:1598 > > +static VisiblePosition leftWordPositionIgnoreEditableBoundary(const VisiblePosition& visiblePosition) > > We normally use AcrossEditingBoundary instead of IgnoringEditingBoundary. ap commented in issue 65277 (https://bugs.webkit.org/show_bug.cgi?id=65277#c32) that "Both names mean that the result will always be across boundary, which is apparently untrue.". So, I am changing "Across" to "Ignoring" which means it ignores editing boundary, could return a position inside editing boundary or across editing boundary.
Ryosuke Niwa
Comment 4 2011-08-18 14:16:07 PDT
(In reply to comment #3) > ap commented in issue 65277 (https://bugs.webkit.org/show_bug.cgi?id=65277#c32) that > "Both names mean that the result will always be across boundary, which is apparently untrue.". > > So, I am changing "Across" to "Ignoring" which means it ignores editing boundary, could return a position inside editing boundary or across editing boundary. Okay. I agree with ap on second thought so let's rename these to IgnoringEditingBoundary (NOT IgnoreEditingBoundary).
Xiaomei Ji
Comment 5 2011-08-18 14:55:30 PDT
Created attachment 104400 [details] patch
Xiaomei Ji
Comment 6 2011-08-18 16:06:02 PDT
Committed r93368: <http://trac.webkit.org/changeset/93368>
Note You need to log in before you can comment on or make changes to this bug.