Bug 66417
| Summary: | [chromium] fast/text/midword-break-before-surrogate-pair-2.html should be redesigned | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | bashi, eae, leviw, mitz, pkasting, rniwa, schenney |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Tony Chang
The following layout test is failing on Chromium Win and Linux
fast/text/midword-break-before-surrogate-pair-2.html
Probable cause:
We don't have glyphs for the emoji characters used in the test. It would be nice if we could have the test use a different character.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Ftext%2Fmidword-break-before-surrogate-pair-2.html
I will mark as failing for now.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Peter Kasting
Also fails on Lion.
Peter Kasting
From eseidel: "I argue the test is poorly designed and needs to be fixed to work better across platforms."
From rniwa: "We should just skip these tests."
I tend to side with eseidel here but what do I know.
The Lion results changed with http://trac.webkit.org/changeset/124295 so this test is pretty sensitive to wrapping issues.
Ryosuke Niwa
Dan, isn't this test supposed to be ran only on Lion and onwards? We should probably move it to platform/mac.
mitz
There was nothing platform-specific about the code change that this test covers, but I don’t know if non-OS X platforms have a font that would make it possible to test this. It seems OK to move the test to platform/mac.
Ryosuke Niwa
(In reply to comment #4)
> There was nothing platform-specific about the code change that this test covers, but I don’t know if non-OS X platforms have a font that would make it possible to test this. It seems OK to move the test to platform/mac.
Can we reproduce the bug you were fixing using some other surrogate pairs?
mitz
(In reply to comment #5)
> (In reply to comment #4)
> > There was nothing platform-specific about the code change that this test covers, but I don’t know if non-OS X platforms have a font that would make it possible to test this. It seems OK to move the test to platform/mac.
>
> Can we reproduce the bug you were fixing using some other surrogate pairs?
Like I said, I don’t know. I think none of the test fonts cover non-BMP characters.
Ryosuke Niwa
Levi, maybe you can look into this while you fix the midpoint bug in isolate.