Bug 66400

Summary: Fix TestWebKitAPI build on Mac OS
Product: WebKit Reporter: Dmitry Lomov <dslomov>
Component: Tools / TestsAssignee: Dmitry Lomov <dslomov>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Added ICU headers to HEADER_SEARCH_PATH.
levin: review+, levin: commit-queue-
Fix style nits. none

Dmitry Lomov
Reported 2011-08-17 13:05:45 PDT
StringOperations.cpp fail to build due to ICU headers missing
Attachments
Added ICU headers to HEADER_SEARCH_PATH. (1.73 KB, patch)
2011-08-17 13:08 PDT, Dmitry Lomov 		levin: review+
levin: commit-queue-
DetailsFormatted DiffDiff
Fix style nits. (1.73 KB, patch)
2011-08-17 13:20 PDT, Dmitry Lomov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dmitry Lomov
Comment 1 2011-08-17 13:08:41 PDT
Created attachment 104218 [details] Added ICU headers to HEADER_SEARCH_PATH.
Mark Rowe (bdash)
Comment 2 2011-08-17 13:11:28 PDT
Comment on attachment 104218 [details] Added ICU headers to HEADER_SEARCH_PATH. View in context: https://bugs.webkit.org/attachment.cgi?id=104218&action=review > Tools/ChangeLog:4 > + Fix TestWebKitAPI build on MacOS. Mac OS. > Tools/ChangeLog:8 > + * TestWebKitAPI/Configurations/Base.xcconfig:Added ICU headers to the HEADER_SEARCH_PATH. We typically leave some space after the colon rather than jamming the message right up against it.
Dmitry Lomov
Comment 3 2011-08-17 13:17:10 PDT
(In reply to comment #2) > We typically leave some space after the colon rather than jamming the message right up against it. check-webkit-style should report this.
Dmitry Lomov
Comment 4 2011-08-17 13:20:25 PDT
Created attachment 104221 [details] Fix style nits.
Dmitry Lomov
Comment 5 2011-08-17 16:22:25 PDT
(In reply to comment #3) > (In reply to comment #2) > > > We typically leave some space after the colon rather than jamming the message right up against it. > > check-webkit-style should report this. https://bugs.webkit.org/show_bug.cgi?id=66425
WebKit Review Bot
Comment 6 2011-08-17 21:47:31 PDT
Comment on attachment 104221 [details] Fix style nits. Clearing flags on attachment: 104221 Committed r93282: <http://trac.webkit.org/changeset/93282>
WebKit Review Bot
Comment 7 2011-08-17 21:47:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.